Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webui: fixes normalization of value in attributes widget #554

Closed
wants to merge 1 commit into from

Conversation

pvoborni
Copy link
Member

@pvoborni pvoborni commented Mar 8, 2017

Fix is in checkboxes widget but the only affected one is attributes widget.

Reproduction:

  1. Add permission with attribute with uppercase character
    $ ipa permission-add aa_test --type=stageuser --attrs=businessCategory --right=read
  2. Check if it is correctly displayed in Web UI

Actual result:

  • businesscategory is not checked
    Expected result:
  • businesscategory is checked

Fix is in checkboxes widget but the only affected one is attributes widget.

Reproduction:
 1. Add permission with attribute with uppercase character
   $ ipa permission-add aa_test --type=stageuser --attrs=businessCategory --right=read
 2. Check if it is correctly displayed in Web UI

Actual result:
 - businesscategory is not checked
Expected result:
 - businesscategory is checked
@pvomacka pvomacka self-requested a review March 8, 2017 13:52
@pvomacka pvomacka added the ack Pull Request approved, can be merged label Mar 8, 2017
@ghost ghost added the pushed Pull Request has already been pushed label Mar 8, 2017
@ghost
Copy link

ghost commented Mar 8, 2017

master:

  • 56a2642 webui: fixes normalization of value in attributes widget

@ghost ghost closed this Mar 8, 2017
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
2 participants