Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

certmap: load certificate from file in certmap-match CLI #557

Closed
wants to merge 1 commit into from
Closed

certmap: load certificate from file in certmap-match CLI #557

wants to merge 1 commit into from

Conversation

HonzaCholasta
Copy link
Contributor

@HonzaCholasta HonzaCholasta commented Mar 9, 2017

Load the certificate from a file specified in the first argument. Raw
certificate value can be specified using --certificate.

https://pagure.io/freeipa/issue/6646

Load the certificate from a file specified in the first argument. Raw
certificate value can be specified using --certificate.

https://pagure.io/freeipa/issue/6646
@ghost ghost self-assigned this Mar 9, 2017
@flo-renaud flo-renaud self-assigned this Mar 9, 2017
@flo-renaud
Copy link
Contributor

Hi @HonzaCholasta
thank you for this patch. There is a minor issue when --certificate is specified multiple times:

ipa  certmap-match  --certificate $CERT1 --certificate $CERT2
ipa: ERROR: invalid 'certificate': must be binary data

Otherwise, it works as expected.

@HonzaCholasta
Copy link
Contributor Author

@flo-renaud, looks like you have found an issue in the framework, but it is unrelated to this PR. It can be reproduced in other commands as well, e.g.:

$ ipa user-mod jcholast --uid a --uid b
ipa: ERROR: invalid 'uid': must be an integer

@HonzaCholasta
Copy link
Contributor Author

@flo-renaud, is there anything else or is the PR good to push?

@flo-renaud
Copy link
Contributor

@HonzaCholasta
Sorry, I forgot to ACK. You can push the PR.
For the record, Issue 6746 has been opened for the framework issue.

@flo-renaud flo-renaud added the ack Pull Request approved, can be merged label Mar 13, 2017
@HonzaCholasta
Copy link
Contributor Author

master:

  • 0298ecf certmap: load certificate from file in certmap-match CLI

@HonzaCholasta HonzaCholasta added the pushed Pull Request has already been pushed label Mar 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
2 participants