ldap2: fix crash in development mode #561
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems to work all right, but the locking issue still affects other parts of the code. For example, I'm not sure if that's in the ticket's scope or not. |
|
Let's see what Travis detects. |
|
Travis didn't detect anything else, so I think we are good to go. Shall we keep the |
|
Yes but please split it into a separate patch so that CI-related changes are tracked separately and do not pollute the changes in the code. |
|
Turns out unsetting mode in default.conf is not good enough, one has to explicitly set it to "development" to enable development mode, because "production" is the default. Let's see if Travis detects something this time. |
added 2 commits
March 10, 2017 14:13
Do not set or delete attributes directly on KerberosWSGIExecutioner, ldap2 and ra_lightweight_ca instances, as that raises an AttributeError in development mode because of ReadOnly locking. Use the usual workaround of `object.__setattr__` and `object.__delattr__` to fix the issue. https://pagure.io/freeipa/issue/6625
Set `mode` to `development` in default.conf after ipa-server-install. https://pagure.io/freeipa/issue/6625
|
OK everything is green now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not set or delete attributes directly on the ldap2 instance, as that
raises an AttributeError in development mode because of ReadOnly locking.
Use the usual workaround of
object.__setattr__andobject.__delattr__to fix the issue.
https://pagure.io/freeipa/issue/6625