ipatests: Skip test_jsplugins in server-less environments #5680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test assumes that IPA server is installed and configured. But test_jsplugins is the subtask of fasttest which is designed (unittest) to be run in server less environment. Note: `needs_ipaapi` is not completely suitable because there is no direct IPA API usage. `xmlrpc_setup` fixture is also not suitable because it assumes XMLRPC. Fixes: https://pagure.io/freeipa/issue/8781 Signed-off-by: Stanislav Levin <slev@altlinux.org>
|
LGTM. ACK |
abbra
added
ack
|
master:
|
This was referenced Mar 30, 2021
|
@abbra, thank you for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test assumes that IPA server is installed and configured.
But test_jsplugins is the subtask of fasttest which is designed
(unittest) to be run in server-less environment.
Note:
needs_ipaapiis not completely suitable because there isno direct IPA API usage.
xmlrpc_setupfixture is also notsuitable because it assumes XMLRPC.
Fixes: https://pagure.io/freeipa/issue/8781