Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebUI: Add support for AD users short name resolution #577

Closed
wants to merge 1 commit into from

Conversation

pvomacka
Copy link

@pvomacka pvomacka commented Mar 13, 2017

@pvoborni
Copy link
Member

LGTM

@pvoborni
Copy link
Member

ACK if backend won't change

Copy link
Contributor

@simo5 simo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add comment in commit message that explain what is done, do not just link a ticket (no just a subject is not sufficient, even for trivial commits)

@pvomacka
Copy link
Author

@simo5 I changed the subject, do you have any suggestion what you would like to see in commit message? I think that this is quite easy and self-explanatory patch.

Added field into idview details page and into server config where
the order of domains used while searching for user. Domains can
be separated by ':' character.

https://pagure.io/freeipa/issue/6372
@MartinBasti MartinBasti added the ack Pull Request approved, can be merged label Mar 14, 2017
@MartinBasti
Copy link
Contributor

master:

  • 2c194d7 WebUI: Add support for management of user short name resolution

@MartinBasti MartinBasti added the pushed Pull Request has already been pushed label Mar 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
4 participants