Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverity: fix bad use of null-like value in cert.py #578

Closed
wants to merge 1 commit into from

Conversation

tkrizek
Copy link
Contributor

@tkrizek tkrizek commented Mar 13, 2017

No description provided.

@apophys
Copy link
Contributor

apophys commented Mar 13, 2017

Please do not post links to internal Red Hat resources in public.

@stlaz
Copy link
Contributor

stlaz commented Mar 13, 2017

Shame on you, @tomaskrizek

@MartinBasti
Copy link
Contributor

I would rather focus on why principal_obj is not defined there

@stlaz
Copy link
Contributor

stlaz commented Mar 14, 2017

if you look at steps 2, 4 and 13 in the Synopsis report (sorry, community!), you will see that this is a false positive. Anyone, please close this as "rejected" to confirm.

@tkrizek
Copy link
Contributor Author

tkrizek commented Mar 14, 2017

Sorry about the link, I've removed it.

Nevertheless, it seems that's indeed a false positive, because principal_type is set to USER, but principal_type == KRBTGT on L616 is evaluated as true instead of principal_type == USER at L624 which would set principal_obj. There is no other assignment to principal_type in between.

Closing the PR, coverity error is a false positive.

@tkrizek tkrizek closed this Mar 14, 2017
@tkrizek tkrizek added the rejected Pull Request has been rejected label Mar 14, 2017
@MartinBasti
Copy link
Contributor

But this is about principal_obj, I don't see it in step 2, but I see principal_obj = None in step 11

@MartinBasti
Copy link
Contributor

Ah I see it is really false positive

@tkrizek tkrizek deleted the coverify-fix-cert-plugin branch September 15, 2017 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rejected Pull Request has been rejected
Projects
None yet
4 participants