Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pkinit from ipa-replica-prepare #582

Closed
wants to merge 1 commit into from
Closed

Remove pkinit from ipa-replica-prepare #582

wants to merge 1 commit into from

Conversation

stlaz
Copy link
Contributor

@stlaz stlaz commented Mar 14, 2017 •
edited by MartinBasti

The PKINIT feature is not available on domain level 0 so any
options about pkinit are false.

https://pagure.io/freeipa/issue/6759

@stlaz
Remove pkinit from ipa-replica-prepare
f973b86 
The PKINIT feature is not available on domain level 0 so any
options about pkinit are false.

https://pagure.io/freeipa/issue/6759
@MartinBasti MartinBasti self-assigned this Mar 14, 2017
@MartinBasti
Copy link
Contributor

Works for me. @abbra @simo5 do you have any objections?

@MartinBasti MartinBasti requested review from abbra and simo5 March 14, 2017 14:49
@abbra
Copy link
Contributor

abbra commented Mar 14, 2017

LGTM.

@HonzaCholasta
Copy link
Contributor

The options were available since forever, so I guess you should just hide them instead of removing them.

The same options are still available in domain level 0 ipa-server-install - is this intentional?

@abbra
Copy link
Contributor

abbra commented Mar 14, 2017

They were in DL0 in ipa-server-install for very long time and never worked. We left them there to make sure we can get them back to work sometime later. We did but in new design ipa-replica-prepare does not need to use these options, unlike ipa-server-install.

@MartinBasti MartinBasti added ack Pull Request approved, can be merged pushed Pull Request has already been pushed labels Mar 15, 2017
@MartinBasti
Copy link
Contributor

master:

  • 46d4d53 Remove pkinit from ipa-replica-prepare

@stlaz stlaz deleted the prepare_pkinit branch September 11, 2017 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbra abbra Awaiting requested review from abbra

@simo5 simo5 Awaiting requested review from simo5

Assignees

@MartinBasti MartinBasti

Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
Milestone
No milestone
4 participants
@stlaz @MartinBasti @abbra @HonzaCholasta