Add make devcheck for developers #593
Conversation
tiran
force-pushed
the
patchcheck
branch
3 times, most recently
from
2bf52da
to
561de31
Compare
tiran
changed the title
ipatests/util.py
Outdated
| >>> expected = [u'Hello', dict(world=u'how are you?')] | ||
| >>> got = [u'Hello', dict(world='how are you?')] | ||
| >>> expected = [u'Hello', dict(world=1)] | ||
| >>> got = [u'Hello', dict(world=1.0)] |
There was a problem hiding this comment.
The old test scenario does no longer work on Python 3 since u'how are you' and 'how are you' have identical type. u'how are you' != b'how are you'. It works with int / float on all Python versions.
ipatests/util.py
Outdated
| expected = u'how are you?' | ||
| got = 'how are you?' | ||
| path = (0, 'world') | ||
| type(expected) = <... 'int'> |
There was a problem hiding this comment.
Python 2 has <type 'int'> while Python 3 uses <class 'int'>.
Makefile.am
Outdated
| @@ -152,6 +152,35 @@ JSLINT_TARGET = jslint | |||
| endif WITH_JSLINT | |||
| lint: acilint apilint $(POLINT_TARGET) $(PYLINT_TARGET) $(JSLINT_TARGET) | |||
|
|
|||
| .PHONY: patchcheck | |||
| patchcheck: all | |||
There was a problem hiding this comment.
This is a major nitpick but could it rather be called develcheck? The two ch in close succession don't quite roll of my keyboard, if that's not an intention.
There was a problem hiding this comment.
Python uses patchcheck, so I'm used to it. But I don't mind to switch to devcheck, develcheck, commitcheck or similar.
By the way, make has tab completion :)
Use the tab, Luke!
There was a problem hiding this comment.
devcheck seems fine to me :)
tiran
changed the title
tiran
force-pushed
the
patchcheck
branch
2 times, most recently
from
5ef4045
to
f41cdac
Compare
|
The changes to Makefile and configure.ac are just fine. I understand that changes in the |
|
|
|
Whichever is ok with you, I don't mind if it's in the same PR if it is related to the same ticket. |
|
I split the changes to session storage tests into a separate commit. The other commit is in #670 |
|
Thanks, ACK. |
|
@MartinBasti #670 was ACKed already and the commit was originally a part of this. |
|
Ah right the description hasn't been updated |
|
Needs rebase |
Ticket 6604 makes pylint and jsl optional dependencies. The change is controversal, because some developers prefer that pylint and jsl should be required unless explicitly disabled. `make devcheck` is my answer to address the concerns. It's a superior solution to `make lint` as pre-commit check. It combines several additional checks under a single, easy rememberable and convenient make target: * build all * acilint, apiclient, jslint, polint * make check * pylint under Python 2 and 3 * subset of unit test suite https://fedorahosted.org/freeipa/ticket/6604 Signed-off-by: Christian Heimes <cheimes@redhat.com>
The test class depends on a working Kerberos configuration and session. Signed-off-by: Christian Heimes <cheimes@redhat.com>
Ticket 6604 makes pylint and jsl optional dependencies. The change
is controversal, because some developers prefer that pylint and jsl
should be required unless explicitly disabled.
make patchcheckis my answer to address the concerns. It's a superiorsolution to
make lintas pre-commit check. It combines severaladditional checks under a single, easy rememberable and convenient make
target:
https://fedorahosted.org/freeipa/ticket/6604
Depends on