Fix Python 3 pylint errors #594
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stlaz
reviewed
Mar 15, 2017
ipapython/install/core.py
Outdated
| @@ -160,7 +159,7 @@ def _knob(type=_missing, default=_missing, bases=_missing, _order=_missing, | |||
|
|
|||
| if bases is _missing: | |||
| bases = (KnobBase,) | |||
| elif isinstance(bases, types.TypeType): | |||
| elif isinstance(bases, type): | |||
There was a problem hiding this comment.
No, it's the same thing since Python 2.2 and has been removed from Python 3:
$ python2.7
>>> import types
>>> types.TypeType is type
True
$ python3.5
>>> import types
>>> types.TypeType is type
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
AttributeError: module 'types' has no attribute 'TypeType'
There was a problem hiding this comment.
argh! the function shadows the builtin type.
tiran
force-pushed
the
pylint_py3
branch
2 times, most recently
from
db76394
to
31b7eed
Compare
************* Module ipaserver.install.ipa_kra_install ipaserver/install/ipa_kra_install.py:25: [W0402(deprecated-module), ] Uses of a deprecated module 'optparse') ************* Module ipapython.install.core ipapython/install/core.py:163: [E1101(no-member), _knob] Module 'types' has no 'TypeType' member) ************* Module ipatests.test_ipapython.test_dn ipatests/test_ipapython/test_dn.py:1205: [W1505(deprecated-method), TestDN.test_x500_text] Using deprecated method assertEquals()) ************* Module ipa-ca-install install/tools/ipa-ca-install:228: [E1101(no-member), install_master] Instance of 'ValueError' has no 'message' member) install/tools/ipa-ca-install:232: [E1101(no-member), install_master] Instance of 'ValueError' has no 'message' member) Signed-off-by: Christian Heimes <cheimes@redhat.com>
|
@stlaz I fixed the problem with shadowed builtin type |
|
master:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Christian Heimes cheimes@redhat.com