spec file: support client-only build #596
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can also move few dependencies to server only build Check spec file changes in rejected PR https://github.com/freeipa/freeipa/pull/494/files otherwise LGTM |
|
I can't, both are required to build client components ( |
|
|
|
Client only build does not work on Fedora. So NACK. |
|
On (15/03/17 02:32), Jan Cholasta wrote:
I can't, both are required to build client components (`ipa-getkeytab` specifically), moving them to the server section would break client-only RPM build.
Sorry for confusion. I misinterpreted changes in diff.
The real change was moving following part to server only build
```
# %{_unitdir}, %{_tmpfilesdir}
BuildRequires: systemd
# systemd-tmpfiles which is executed from make install requires apache user
BuildRequires: httpd
```
But git diff decided to show moving of other lines
LS
|
|
This PR now depends on PR #597. |
|
@HonzaCholasta Thank you for update - only client build on Fedora now works. So ACK once the travis pass. |
|
ipa server build without tests does not work, so NACK |
|
Now that PR #502 was pushed this should finally work. |
|
master:
|
nspr-devel, nss-devel and openssl-devel are required for client-only build,
move their respective BuildRequires from the server-specific BuildRequires
section to the main BuildRequires section.
Pass --enable-server or --disable-server to ./configure based on the value
of %{ONLY_CLIENT}.
Remove the `make client-check` call from %check, as the client-check target
does not exist anymore. Always call `make check` instead.
Do not package the /usr/share/ipa directory in freeipa-client-common, as it
is not created in client-only build.
https://pagure.io/freeipa/issue/6517
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nspr-devel, nss-devel and openssl-devel are required for client-only build,
move their respective BuildRequires from the server-specific BuildRequires
section to the main BuildRequires section.
Pass --enable-server or --disable-server to ./configure based on the value
of %{ONLY_CLIENT}.
Remove the
make client-checkcall from %check, as the client-check targetdoes not exist anymore. Always call
make checkinstead.Do not package the /usr/share/ipa directory in freeipa-client-common, as it
is not created in client-only build.
https://pagure.io/freeipa/issue/6517