[4.3] Fix cookie with Max-Age processing #610
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinBasti
reviewed
Mar 16, 2017
ipalib/rpc.py
Outdated
| session_cookie = Cookie.get_named_cookie_from_string( | ||
| cookie_string, COOKIE_NAME, | ||
| timestamp=datetime.datetime.utcnow()) | ||
| except Exception: |
There was a problem hiding this comment.
Debug log here might be useful, right?
There was a problem hiding this comment.
Sure, why not. I was just porting the code not really looking that way or another.
There was a problem hiding this comment.
In that case, create another commit that can be applied to master and 4.5 branch as well
|
Please open a new ticket |
When cookie has Max-Age set it tries to get expiration by adding to a timestamp. Without this patch the timestamp would be set to None and thus the addition of timestamp + max_age fails https://pagure.io/freeipa/issue/6774
|
The ticket's already there, I just recycled the old commit message and forgot to replace it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cookie has Max-Age set it tries to get expiration by adding
to a timestamp. Without this patch the timestamp would be set to
None and thus the addition of timestamp + max_age fails
https://pagure.io/freeipa/issue/6718