Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pytest 3.x compatibility #619

Closed
wants to merge 1 commit into from
Closed

pytest 3.x compatibility #619

wants to merge 1 commit into from

Conversation

tiran
Copy link
Member

@tiran tiran commented Mar 17, 2017 •
edited by pvomacka

pytest 3.x does no longer support plain pytest.skip() on module level.

Signed-off-by: Christian Heimes cheimes@redhat.com

@tiran tiran requested a review from martbab March 17, 2017 17:22
@MartinBasti
Copy link
Contributor 

************* Module ipatests.util
ipatests/util.py:73: [E1123(unexpected-keyword-arg), check_ipaclient_unittests] Unexpected keyword argument 'allow_module_level' in constructor call)

@tiran
pytest 3.x compatibility
4810603 
pytest 3.x does no longer support plain pytest.skip() on module level.

Signed-off-by: Christian Heimes <cheimes@redhat.com>
@tiran
Copy link
Member Author

tiran commented Mar 22, 2017

@martbab @MartinBasti Do you agree with the workaround or do you want to suggest a different approach?

@MartinBasti
Copy link
Contributor

LGTM

@MartinBasti MartinBasti added the ack Pull Request approved, can be merged label Mar 27, 2017
@pvomacka pvomacka added the pushed Pull Request has already been pushed label Mar 27, 2017
@pvomacka
Copy link

master:

@pvomacka pvomacka closed this Mar 27, 2017
@tiran tiran deleted the pytest3_compat branch April 4, 2017 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martbab martbab Awaiting requested review from martbab

Assignees

@martbab martbab

Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
Milestone
No milestone
4 participants
@tiran @MartinBasti @pvomacka @martbab