Move helper code for integration plugin

[tiran]

fd1b4f6 broke integration tests because the integration helper imports code from ``ipatests.test_integration```.

Traceback (most recent call last):
  File "/usr/bin/ipa-test-config", line 30, in <module>
    from ipatests.test_integration import config, env_config
  File "/usr/lib/python2.7/site-packages/ipatests/test_integration/__init__.py", line 22, in <module>
    if pytest.config.getoption('ipaclient_unittests', False):
AttributeError: 'module' object has no attribute 'config'

Helper code for ipatests.pytest_plugins.integration was in ipatests.test_integration. This doesn't play nice with pytests auto-discovery of test cases. Certain aspects of pytest are not available right away. For example pytest.config is generated after configuration stage but before discovery stage.

Now all helper code is next to the plugin in ipatests.pytest_plugins.integration (which is now a package).

https://pagure.io/freeipa/issue/6798

[pvoborni]

From the PR description it is not clear what problem it solves or if it solves a problem.
"doesn't play nice " is vague.

" Certain aspects of pytest are not available right away. For example pytest.config is generated after configuration stage but before discovery stage." Is a description of reality, not a problem.

In other word. Why is this needed? And I'm not implying it is not needed, just the PR comment doesn't explain it.

[apophys]

LGTM with one issue I commented inline. The helper scripts work with these commits. Thanks for fixing the issue.

[apophys]

Since we are moving the modules into a package, why do we keep this module around? I do not know the rationale for the util module in here but the functions could move to ipatests/pytest_plugins/integration/tasks.py, with appropriate changes to test_legacy_clients, test_sudo and test_trust modules.

[apophys]

Adding to this, shouldn't we move the ipatests/test_integration/base.py module as well?

[tiran]

base.py provides base class for all integration tests. The pytest plugin doesn't depend on the base class directly IMO it makes more sense to keep it next to the test cases.

For the other functions in module, I don't really care. If you prefer to have them in tasks, I'm happy to move them, too.

[apophys]

You're right that the plugin itself does not depend on the integration test base class. As for the functions in the utils module, please move them to tasks.

[apophys]

Thanks for the update

[tiran]

@apophys Please create a ticket for the issue. This PR should not get merged until the issue is properly documented in a ticket and commit messages have been updated.

[apophys]

will do

[tiran]

@apophys has created ticket https://pagure.io/freeipa/issue/6798 and I have updated all commit messages.

[tkrizek]

master:

• dde71ec Move helper code for integration plugin

• 2895e39 Move config module to ipatests.pytest_plugins.integration.config

• 1406dbc Move env_config module to ipatests.pytest_plugins.integration.env_config

• 313ae46 Move tasks module to ipatests.pytest_plugins.integration.tasks

• 8867412 Move hosts module to ipatests.pytest_plugins.integration.hosts

• 8aadd55 Move function run_repeatedly to tasks module

• 5587a37 Ship ipatests.pytest_plugins.integration

• 24161a6 Move remaining util functions to tasks module
  ipa-4-5:

• 1199416 Move helper code for integration plugin

• 025a19c Move config module to ipatests.pytest_plugins.integration.config

• e257bbd Move env_config module to ipatests.pytest_plugins.integration.env_config

• 321437c Move tasks module to ipatests.pytest_plugins.integration.tasks

• 6789dac Move hosts module to ipatests.pytest_plugins.integration.hosts

• 4c62c41 Move function run_repeatedly to tasks module

• 87b60f3 Ship ipatests.pytest_plugins.integration

• cd79184 Move remaining util functions to tasks module