WebUI: Remove offline version of WebUI #628
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Self-NACK, build fails. |
pvoborni
requested changes
Mar 24, 2017
There was a problem hiding this comment.
Only data dir and tests related to it should be removed. You are also removing whole test directory but there are also unit tests like binding_tests.js, build_test.js, certificate_test.js, ip_tests.js, ordered_map_tests.js, utils_test,js which we should kept because they have value. Issue is that they are not in CI and we should focus(different PR) on running them there. Could be in a different test framework.
pvomacka
force-pushed
the
t6447
branch
2 times, most recently
from
46c9535
to
250a77b
Compare
|
I returned back test files and removed only JSON files. I also created ticket which proposes fixing WebUI unit tests, as you mentioned. https://pagure.io/freeipa/issue/6974 |
added 4 commits
August 21, 2017 11:45
This reverts commit 24525fd. The reverted commit removed symlinks which allowed unit tests to access FreeIPA code. https://pagure.io/freeipa/issues/6447
JSON files were used as source of information for offline WebUI. https://pagure.io/freeipa/issue/6447
The plugins symlink points to non-existing directory and is currently not used. It also causes errors in freeipa-pr-ci during creating tarball. https://pagure.io/freeipa/issue/6447
This patchset returns back js directory with its symlinks into the repository so it does not need to be created during build. https://pagure.io/freeipa/issue/6447
pvoborni
approved these changes
Aug 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all json files which were used for testing WebUI offline and are no more useful. Also removes all lines in other files/scripts which refer to the offline version of WebUI.
https://pagure.io/freeipa/issue/6447