Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipapython.ipautil.nolog_replace: Do not replace empty value #630

Closed
wants to merge 1 commit into from
Closed

ipapython.ipautil.nolog_replace: Do not replace empty value #630

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 20, 2017

When provided empty value in nolog parameter nolog_replace added 'XXXXXXXX'
three (once for plain value, once for http quoted value and last time for shell
quoted value) times before every character (including terminating '\0') in the string.

https://pagure.io/freeipa/issue/6738

When provided empty value in nolog parameter nolog_replace added 'XXXXXXXX'
three (once for plain value, once for http quoted value and last time for shell
quoted value) times before every character (including terminating '\0') in the string.

https://pagure.io/freeipa/issue/6738
@ghost ghost requested a review from pvomacka March 20, 2017 12:00
@ghost ghost assigned pvomacka Mar 21, 2017
@pvomacka pvomacka added the ack Pull Request approved, can be merged label Mar 21, 2017
@pvomacka pvomacka added the pushed Pull Request has already been pushed label Mar 21, 2017
@pvomacka
Copy link

ipa-4-5:

  • 8f0c7df ipapython.ipautil.nolog_replace: Do not replace empty value
    master:

  • 4297ad6 ipapython.ipautil.nolog_replace: Do not replace empty value
    ipa-4-4:

  • 40e1eb6 ipapython.ipautil.nolog_replace: Do not replace empty value

@pvomacka pvomacka closed this Mar 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
1 participant