Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: configure PKINIT after adding anonymous principal #631

Closed
wants to merge 4 commits into from

Conversation

martbab
Copy link
Contributor

@martbab martbab commented Mar 21, 2017

In order to set up PKINIT, the anonymous principal must already be
created, otherwise the upgrade with fail when trying out anonymous
PKINIT. Switch the order of steps so that this issue does not occur.

https://pagure.io/freeipa/issue/6792

@martbab
Copy link
Contributor Author

martbab commented Mar 22, 2017

self-NACK, I have to fix 4.5.0 -> 4.5.1 upgrade path. I did not realize that yesterday.

@martbab martbab force-pushed the pkinit-upgrade-fix branch 2 times, most recently from 3a4dae5 to e12c9eb Compare March 27, 2017 07:44
@martbab
Copy link
Contributor Author

martbab commented Mar 27, 2017

I have prepared a more thorough fix which should cover more edge cases.

Martin Babinsky added 4 commits March 28, 2017 17:34
In order to set up PKINIT, the anonymous principal must already be
created, otherwise the upgrade with fail when trying out anonymous
PKINIT. Switch the order of steps so that this issue does not occur.

https://pagure.io/freeipa/issue/6792
This allows for more flexibility in the whole PKINIT setup process.

https://pagure.io/freeipa/issue/6792
@stlaz stlaz self-assigned this Mar 29, 2017
@stlaz stlaz added the ack Pull Request approved, can be merged label Mar 29, 2017
@MartinBasti MartinBasti added the pushed Pull Request has already been pushed label Mar 30, 2017
@MartinBasti
Copy link
Contributor

master:

  • c2d95d3 Upgrade: configure PKINIT after adding anonymous principal
  • 1fc48cd Remove unused variable from failed anonymous PKINIT handling
  • 17aa51e Split out anonymous PKINIT test to a separate method
  • 5c22f90 Ensure KDC is propery configured after upgrade

ipa-4-5:

  • b9002bf Upgrade: configure PKINIT after adding anonymous principal
  • 4b2b1d3 Remove unused variable from failed anonymous PKINIT handling
  • c139302 Split out anonymous PKINIT test to a separate method
  • 89fc0a1 Ensure KDC is propery configured after upgrade

@martbab martbab deleted the pkinit-upgrade-fix branch March 30, 2017 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
3 participants