ldap2: use LDAP whoami operation to retrieve bind DN for current connection #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martbab
suggested changes
Mar 22, 2017
ipaserver/plugins/ldap2.py
Outdated
| bind_dn = self.conn.whoami_s()[4:] | ||
| finally: | ||
| if bind_dn is None: | ||
| return None |
There was a problem hiding this comment.
Why do we need a try:..finally block here? I would rather do bind_dn = self.conn.whoami_s()[4:] and let the exception propagate to the callers if something bad happens. Or you may catch it and re-raise some public and more descriptive error.
|
LGTM but lint has some complains probably related to my in-line comment. |
|
Hi @abbra, thank you for patch, works for me. |
…ection For external users which are mapped to some DN in LDAP server, we wouldn't neccesary be able to find a kerberos data in their LDAP entry. Instead of searching for Kerberos principal use actual DN we are bound to because for get_effective_rights LDAP control we only need the DN itself. Fixes https://pagure.io/freeipa/issue/6797
abbra
force-pushed
the
fix-get_effective_rights
branch
from
7201f6d
to
3f92253
Compare
|
Removed try: finally: block, I agree that it is better to propagate error up the stack. |
martbab
approved these changes
Mar 22, 2017
martbab
added
ack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For external users which are mapped to some DN in LDAP server, we
wouldn't neccesary be able to find a kerberos data in their LDAP entry.
Instead of searching for Kerberos principal use actual DN we are bound
to because for get_effective_rights LDAP control we only need the DN
itself.
Fixes https://pagure.io/freeipa/issue/6797