Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configure: fix --disable-server with certauth plugin #657

Closed
wants to merge 2 commits into from
Closed

configure: fix --disable-server with certauth plugin #657

wants to merge 2 commits into from

Conversation

sumit-bose
Copy link
Contributor

@sumit-bose sumit-bose commented Mar 27, 2017 •
edited by pvomacka

@sumit-bose sumit-bose force-pushed the configure_disable_server_certauth_fix branch from bc6aa4f to 5aae02c Compare March 27, 2017 10:37
@lslebodn
Copy link
Contributor

lslebodn commented Mar 27, 2017 •
edited

AM_CONDITIONAL need to be executed every time.

So just AM_CONDITIONAL([BUILD_IPA_CERTAUTH_PLUGIN] need to be moved from sever.m4 -> configure.ac. The best would be to include it somewhere after m4_include(server.m4)

@sumit-bose sumit-bose force-pushed the configure_disable_server_certauth_fix branch from 5aae02c to 3b4f9f3 Compare March 27, 2017 11:22
@tiran
Copy link
Member

tiran commented Mar 27, 2017

LGTM

I verified that the PR fixes

  • --disable-server
  • --enable-server with old version of krb5 that does not have krb5/certauth_plugin.h

@tiran tiran added the ack Pull Request approved, can be merged label Mar 27, 2017
@pvomacka
Copy link

ipa-4-5:

  • 203d541 configure: fix --disable-server with certauth plugin

  • 8fde0b8 ipa-kdb: do not depend on certauth_plugin.h
    master:

  • 054f1bd configure: fix --disable-server with certauth plugin

  • 0ba0c07 ipa-kdb: do not depend on certauth_plugin.h

@pvomacka pvomacka added the pushed Pull Request has already been pushed label Mar 27, 2017
@pvomacka pvomacka closed this Mar 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiran tiran tiran approved these changes

Assignees
No one assigned
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
Milestone
No milestone
4 participants
@sumit-bose @lslebodn @tiran @pvomacka