idrange-add: properly handle empty --dom-name option

[flo-renaud]

When idrange-add is called with --dom-name=, the CLI exits with
ipa: ERROR: an internal error has occurred
This happens because the code checks if the option is provided but does not
check if the value is None.

We need to handle empty dom-name as if the option was not specified.

https://pagure.io/freeipa/issue/6404

[stlaz]

LGTM, except you're talking about idrange-mod in the commit message but are fixing idrange-add (idrange-mod does not have the option at all).

[flo-renaud]

Hi @stlaz
I fixed the commit message.

In contrary to what I told you offline, you need to configure an AD trust with ipa-adtrust-install and ipa trust-add ... in order to reproduce the original issue. My bad...

[stlaz]

@flo-renaud That's completely OK :)
I thought we could probably add an assert to CIDict.__contains__() method since I realize the issue was somewhere else than this fixed check, but the current situation fails verbosely enough so that's probably fine.
ACK.

[martbab]

@flo-renaud can you please add a test case for this to ipatests/test_xmlrpc/test_range_plugin.py so that we do not regress in the future?

[tkrizek]

master:

• 70743c8 idrange-add: properly handle empty --dom-name option

ipa-4-5:

• 077a615 idrange-add: properly handle empty --dom-name option

[flo-renaud]

@martbab
thank you for the suggestion. The new test is available in PR #692