Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec file: bump libsss_nss_idmap-devel BuildRequires #668

Closed
wants to merge 1 commit into from
Closed

spec file: bump libsss_nss_idmap-devel BuildRequires #668

wants to merge 1 commit into from

Conversation

HonzaCholasta
Copy link
Contributor

@HonzaCholasta HonzaCholasta commented Mar 29, 2017

Bump BuildRequires on libsss_nss_idmap-devel to the version which
introduces the sss_nss_getlistbycert function.

This fixes RPM build failure when an older version of
libsss_nss_idmap-devel was installed.

https://pagure.io/freeipa/issue/6826

@tkrizek
Copy link
Contributor

tkrizek commented Mar 29, 2017

Do we also need to bump the version in PKG_CHECK_MODULES in server.m4:31?

PKG_CHECK_MODULES([SSSNSSIDMAP], [sss_nss_idmap >= 1.15.2])

@abbra
Copy link
Contributor

abbra commented Mar 29, 2017

No, It will make downstream harder because RHEL downstream will only have 1.15.2 with patches on top of that version.

I have a pull request coming that actually checks for a specific function we know is part of those SSSD patches.

@abbra
Copy link
Contributor

abbra commented Mar 29, 2017

I submitted #669 for that

@tkrizek
Copy link
Contributor

tkrizek commented Mar 29, 2017

We still want to merge this PR to take care of the upstream BuildRequires though, right?

@HonzaCholasta
Copy link
Contributor Author

Right.

@tkrizek tkrizek added the ack Pull Request approved, can be merged label Mar 29, 2017
Bump BuildRequires on libsss_nss_idmap-devel to the version which
introduces the sss_nss_getlistbycert function.

This fixes RPM build failure when an older version of
libsss_nss_idmap-devel was installed.

https://pagure.io/freeipa/issue/6828
@HonzaCholasta
Copy link
Contributor Author

Changed ticket link to https://pagure.io/freeipa/issue/6828.

@tkrizek
Copy link
Contributor

tkrizek commented Mar 29, 2017

master:

  • b18ee8b spec file: bump libsss_nss_idmap-devel BuildRequires
    ipa-4-5:

  • 127f7ce spec file: bump libsss_nss_idmap-devel BuildRequires

@tkrizek tkrizek added the pushed Pull Request has already been pushed label Mar 29, 2017
@tkrizek tkrizek closed this Mar 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
3 participants