Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: make sure we test for sss_nss_getlistbycert #669

Closed
wants to merge 1 commit into from
Closed

server: make sure we test for sss_nss_getlistbycert #669

wants to merge 1 commit into from

Conversation

abbra
Copy link
Contributor

@abbra abbra commented Mar 29, 2017 •
edited by tkrizek

@abbra abbra mentioned this pull request Mar 29, 2017
Closed
@tiran
Copy link
Member

tiran commented Mar 29, 2017

AC_CHECK_LIB only checks for functions in libs. Compilation may still fail if header files and library are not in sync. IMHO we don't have to care about this broken case.

LGTM

@abbra
Copy link
Contributor Author

abbra commented Mar 29, 2017

On the systems where pkg-config is available, positive result from pkg-config check means headers are available because pkg-config files are part of development sub-packages. Symbol check in a library is enough then.

@tkrizek
Copy link
Contributor

tkrizek commented Mar 29, 2017

Works as expected.

@tkrizek tkrizek added ack Pull Request approved, can be merged pushed Pull Request has already been pushed labels Mar 29, 2017
@tkrizek
Copy link
Contributor

tkrizek commented Mar 29, 2017

master:

  • 67e5244 server: make sure we test for sss_nss_getlistbycert
    ipa-4-5:

  • 8be6987 server: make sure we test for sss_nss_getlistbycert

@tkrizek tkrizek closed this Mar 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
Milestone
No milestone
3 participants
@abbra @tiran @tkrizek