Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slim down dependencies #671

Closed
wants to merge 1 commit into from
Closed

Slim down dependencies #671

wants to merge 1 commit into from

Conversation

tiran
Copy link
Member

@tiran tiran commented Mar 29, 2017 •
edited by MartinBasti

  • Make jinja2 an optional dependency and csrgen an optional plugin
  • Make otptoken_yubikey an optional plugin

Signed-off-by: Christian Heimes cheimes@redhat.com

@tiran tiran force-pushed the slim_packages branch 2 times, most recently from d9906d9 to d53798e Compare April 6, 2017 08:29
@tiran tiran changed the title [WIP] Slim down dependencies Slim down dependencies Apr 6, 2017
@tiran tiran force-pushed the slim_packages branch 2 times, most recently from b12cb1e to 3f0a816 Compare April 10, 2017 08:10
@tiran
Copy link
Member Author

tiran commented Apr 11, 2017

Now depends on PR #702

@MartinBasti MartinBasti self-assigned this Apr 25, 2017
@tiran tiran force-pushed the slim_packages branch 2 times, most recently from f69db99 to 8459a73 Compare April 27, 2017 13:19
@MartinBasti
Copy link
Contributor

Due missing jinja, tox tests failed

ERROR:   py27: commands failed
ERROR:   py35: commands failed
ERROR:   py36: commands failed
ERROR:   pylint2: commands failed
ERROR:   pylint3: commands failed

Tests

ImportError while importing test module '/tmp/freeipa/.tox/py36/lib/python3.6/site-packages/ipatests/test_ipaclient/test_csrgen.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
test_ipaclient/test_csrgen.py:8: in <module>
    from ipaclient import csrgen
../ipaclient/csrgen.py:23: in <module>
    import jinja2
E   ModuleNotFoundError: No module named 'jinja2'

pylint

************* Module ipaclient.csrgen
lib/python3.5/site-packages/ipaclient/csrgen.py:23: [E0401(import-error), ] Unable to import 'jinja2')
lib/python3.5/site-packages/ipaclient/csrgen.py:24: [E0401(import-error), ] Unable to import 'jinja2.ext')
lib/python3.5/site-packages/ipaclient/csrgen.py:25: [E0401(import-error), ] Unable to import 'jinja2.sandbox')

@tiran
Slim down dependencies
de75aaf 
* Make jinja2 an optional dependency and csrgen an optional plugin
* Make otptoken_yubikey an optional plugin

Signed-off-by: Christian Heimes <cheimes@redhat.com>
@MartinBasti MartinBasti added the ack Pull Request approved, can be merged label May 9, 2017
@MartinBasti
Copy link
Contributor

master:

@MartinBasti MartinBasti added the pushed Pull Request has already been pushed label May 9, 2017
@MartinBasti MartinBasti closed this May 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MartinBasti MartinBasti

Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
Milestone
No milestone
2 participants
@tiran @MartinBasti