Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipa-otpd.socket.in: Use a platform specific value for KDC service file #680

Closed
wants to merge 1 commit into from
Closed

ipa-otpd.socket.in: Use a platform specific value for KDC service file #680

wants to merge 1 commit into from

Conversation

tjaalton
Copy link
Contributor

@tjaalton tjaalton commented Mar 31, 2017 •
edited by tkrizek

tiran
tiran requested changes Apr 3, 2017
View reviewed changes
Copy link
Member

@tiran tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find it confusing to have the AC_SUBST in server.m4. Please keep definition and substitution in one file, just like NAMED_GROUP.

@tkrizek
Copy link
Contributor

tkrizek commented Apr 12, 2017 •
edited

I believe Christian's suggestion was addressed in the updated commit. Looks good to me.

@tkrizek tkrizek added the ack Pull Request approved, can be merged label Apr 12, 2017
@tkrizek
Copy link
Contributor

tkrizek commented Apr 12, 2017

master:

  • 076eb40 ipa-otpd.socket.in: Use a platform specific value for KDC service file

@tkrizek tkrizek added the pushed Pull Request has already been pushed label Apr 12, 2017
@tkrizek tkrizek closed this Apr 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiran tiran tiran requested changes

Assignees
No one assigned
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
Milestone
No milestone
3 participants
@tjaalton @tkrizek @tiran