Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install: request service certs after host keytab is set up #698

Closed
wants to merge 6 commits into from
Closed

install: request service certs after host keytab is set up #698

wants to merge 6 commits into from

Conversation

HonzaCholasta
Copy link
Contributor

@HonzaCholasta HonzaCholasta commented Apr 7, 2017

dsinstance: reconnect ldap2 after DS is restarted by certmonger

DS is restarted by certmonger in the restart_dirsrv script after the DS
certificate is saved. This breaks the ldap2 backend and makes any operation
fail with NetworkError until it is reconnected.

Reconnect ldap2 after the DS certificate request is finished to fix the
issue. Make sure restart_dirsrv waits for the ldapi socket so that the
reconnect does not fail.

httpinstance: avoid httpd restart during certificate request

httpd is restarted by certmonger in the restart_httpd script after the
httpd certificate is saved if it was previously running. The restart will
fail because httpd is not properly configured at this point.

Stop httpd at the beginning of httpd install to avoid the restart.

dsinstance, httpinstance: consolidate certificate request code

A different code path is used for DS and httpd certificate requests in
replica promotion. This is rather unnecessary and makes the certificate
request code not easy to follow.

Consolidate the non-promotion and promotion code paths into one.

install: request service certs after host keytab is set up

The certmonger renew agent and restart scripts use host keytab for
authentication. When they are executed during a certmonger request before
the host keytab is set up, the authentication will fail.

Make sure all certmonger requests in the installer are done after the host
keytab is set up.

renew agent: revert to host keytab authentication

Fixes an issue where the renew agent uses GSSAPI for LDAP connection but
fails because it is not authenticated.

This reverts commit 7462ade.

renew agent, restart scripts: connect to LDAP after kinit

Connect to LDAP after kinit is done, otherwise GSSAPI authentication will
fail.

https://pagure.io/freeipa/issue/6757

Jan Cholasta added 6 commits April 7, 2017 07:59
DS is restarted by certmonger in the restart_dirsrv script after the DS
certificate is saved. This breaks the ldap2 backend and makes any operation
fail with NetworkError until it is reconnected.

Reconnect ldap2 after the DS certificate request is finished to fix the
issue. Make sure restart_dirsrv waits for the ldapi socket so that the
reconnect does not fail.

https://pagure.io/freeipa/issue/6757
httpd is restarted by certmonger in the restart_httpd script after the
httpd certificate is saved if it was previously running. The restart will
fail because httpd is not properly configured at this point.

Stop httpd at the beginning of httpd install to avoid the restart.

https://pagure.io/freeipa/issue/6757
A different code path is used for DS and httpd certificate requests in
replica promotion. This is rather unnecessary and makes the certificate
request code not easy to follow.

Consolidate the non-promotion and promotion code paths into one.

https://pagure.io/freeipa/issue/6757
The certmonger renew agent and restart scripts use host keytab for
authentication. When they are executed during a certmonger request before
the host keytab is set up, the authentication will fail.

Make sure all certmonger requests in the installer are done after the host
keytab is set up.

https://pagure.io/freeipa/issue/6757
Fixes an issue where the renew agent uses GSSAPI for LDAP connection but
fails because it is not authenticated.

This reverts commit 7462ade.

https://pagure.io/freeipa/issue/6757
Connect to LDAP after kinit is done, otherwise GSSAPI authentication will
fail.

https://pagure.io/freeipa/issue/6757
@martbab martbab self-assigned this Apr 7, 2017
@martbab martbab added the ack Pull Request approved, can be merged label Apr 7, 2017
@martbab
Copy link
Contributor

martbab commented Apr 7, 2017

master:

  • b189be1 dsinstance: reconnect ldap2 after DS is restarted by certmonger

  • 8a85586 httpinstance: avoid httpd restart during certificate request

  • ec52332 dsinstance, httpinstance: consolidate certificate request code

  • 181cb94 install: request service certs after host keytab is set up

  • 3884a67 renew agent: revert to host keytab authentication

  • a6a89e2 renew agent, restart scripts: connect to LDAP after kinit
    ipa-4-5:

  • 3a3cd01 dsinstance: reconnect ldap2 after DS is restarted by certmonger

  • 029da95 httpinstance: avoid httpd restart during certificate request

  • 3317e17 dsinstance, httpinstance: consolidate certificate request code

  • cb141b0 install: request service certs after host keytab is set up

  • 1a7db62 renew agent: revert to host keytab authentication

  • e9168e8 renew agent, restart scripts: connect to LDAP after kinit

@martbab martbab added the pushed Pull Request has already been pushed label Apr 7, 2017
@martbab martbab closed this Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
2 participants