Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct PyPI package dependencies #702

Closed
wants to merge 2 commits into from
Closed

Correct PyPI package dependencies #702

wants to merge 2 commits into from

Conversation

tiran
Copy link
Member

@tiran tiran commented Apr 10, 2017 •
edited by MartinBasti

  • Remove unused install requires
  • Correct dependencies for yubico otptoken
  • Add explicit dependency on cffi for csrgen
  • Python 2 uses python-ldap, Python 3 pyldap

Signed-off-by: Christian Heimes cheimes@redhat.com

Needs backport to 4.5 for 4.5.1 PyPI packaging.

@tiran tiran mentioned this pull request Apr 11, 2017
Closed
@MartinBasti MartinBasti self-assigned this Apr 11, 2017
@MartinBasti
Copy link
Contributor

For backport to 4.5 ticket and agreement on ticket triage must be done

@tiran
Copy link
Member Author

tiran commented Apr 13, 2017

With recent changes, 4.5 needs a different patch. Let's merge this one and I'll prepare a new one with a ticket another time.

@MartinBasti
Copy link
Contributor

Pylint targets are failing with following errror

Collecting pyusb; extra == "otptoken_yubikey" (from ipaclient==4.5.90.dev201704251040+git0ebdd30->-c /tmp/freeipa/.wheelconstraints (line 5))
  Could not find a version that satisfies the requirement pyusb; extra == "otptoken_yubikey" (from ipaclient==4.5.90.dev201704251040+git0ebdd30->-c /tmp/freeipa/.wheelconstraints (line 5)) (from versions: )
No matching distribution found for pyusb; extra == "otptoken_yubikey" (from ipaclient==4.5.90.dev201704251040+git0ebdd30->-c /tmp/freeipa/.wheelconstraints (line 5))

@tiran
Correct PyPI package dependencies
2120805 
* Remove unused install requires from ipapython
* Add missing requirements to ipaserver
* Correct dependencies for yubico otptoken
* Add explicit dependency on cffi for csrgen
* Python 2 uses python-ldap, Python 3 pyldap

https://pagure.io/freeipa/issue/6875

Signed-off-by: Christian Heimes <cheimes@redhat.com>
@tiran
Band-aid for pip dependency bug
23e3680 
pip install foo foo[more] does not install the extra dependencies 'more'
of foo. It's a known bug in pip, see
pypa/pip#4391 (comment) and
pypa/pip#988

The same bug applies to pip wheel. As a workaround pip wheel first
builds extra dependencies, then wheel dependencies. This ensures that
ipaclient[otptoken_yubikey] dependencies get built properly.

Signed-off-by: Christian Heimes <cheimes@redhat.com>
@tiran
Copy link
Member Author

tiran commented Apr 25, 2017

You are running into a pip bug. I've added band-aid for the issue. To speed up testing, tox caches packages. I guess I never ran into the problem because I had the packages pre-build and cached.

@MartinBasti MartinBasti added the ack Pull Request approved, can be merged label Apr 26, 2017
@MartinBasti
Copy link
Contributor

master:

  • 26ab51d Correct PyPI package dependencies
  • 994d24d Band-aid for pip dependency bug

@MartinBasti MartinBasti added the pushed Pull Request has already been pushed label Apr 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MartinBasti MartinBasti

Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
Milestone
No milestone
2 participants
@tiran @MartinBasti