Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebUI: Coverity fixes #712

Closed
wants to merge 3 commits into from
Closed

WebUI: Coverity fixes #712

wants to merge 3 commits into from

Conversation

pvomacka
Copy link

@pvomacka pvomacka commented Apr 13, 2017 •
edited by MartinBasti

Several fixes:

  • null pointer exception
  • add explicit object
  • removes identical branches of if statement

Pavel Vomacka added 3 commits April 13, 2017 14:34
WebUI: Coverity - add explicit window object to alert methods
bcd280b 
All calls of alert were without explicit object. This commit
adds explicit object window.
WebUI - Coverity: fixed null pointer exception
c3c0909 
The record variable could be null. This check makes sure
that variable won't be null.
WebUI - Coverity: fix identical branches of if statement
112fb16
@tkrizek tkrizek self-assigned this Apr 24, 2017
@tkrizek tkrizek added the ack Pull Request approved, can be merged label Apr 24, 2017
@MartinBasti
Copy link
Contributor

master:

  • b54ceae WebUI: Coverity - add explicit window object to alert methods
  • 5ba7957 WebUI - Coverity: fixed null pointer exception
  • 01516e5 WebUI - Coverity: fix identical branches of if statement

@MartinBasti MartinBasti added the pushed Pull Request has already been pushed label Apr 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tkrizek tkrizek

Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
Milestone
No milestone
3 participants
@pvomacka @MartinBasti @tkrizek