Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tox: use pylint 1.6.x for now #720

Closed
wants to merge 1 commit into from
Closed

tox: use pylint 1.6.x for now #720

wants to merge 1 commit into from

Conversation

tiran
Copy link
Member

@tiran tiran commented Apr 19, 2017 •
edited by MartinBasti

FreeIPA is not yet compatible with pylint 1.7.1+. Enforce pylint 1.6.x
until all issues have been addressed.

Related: https://pagure.io/freeipa/issue/6874
Signed-off-by: Christian Heimes cheimes@redhat.com

@tiran
Copy link
Member Author

tiran commented Apr 19, 2017

Needs rebase to 4.5 or 4.5 must be made compatible with pylint 1.7 before 4.5.1 is released.

@MartinBasti MartinBasti self-assigned this Apr 21, 2017
@MartinBasti
Copy link
Contributor

pylint and pylint3 targets are failing

MAKEFLAGS= /tmp/freeipa/.tox/pylint2/bin/python -m pip wheel \
    --disable-pip-version-check \
    --constraint .wheelconstraints \
    --find-links ./dist/wheels \
    --find-links ./dist/bundle \
    --wheel-dir ./dist/bundle \
    ipaclient ipalib ipapython ipaclient ipapython[certmonger] pylint < 1.7
/bin/sh: 1.7: No such file or directory
Makefile:1249: recipe for target 'wheel_bundle' failed
make: *** [wheel_bundle] Error 1
make: Leaving directory '/tmp/freeipa'

@tiran
tox: use pylint 1.6.x for now
c629f1a 
FreeIPA is not yet compatible with pylint 1.7.1+. Enforce pylint 1.6.x
until all issues have been addressed.

Related: https://pagure.io/freeipa/issue/6874
Signed-off-by: Christian Heimes <cheimes@redhat.com>
@MartinBasti MartinBasti added the ack Pull Request approved, can be merged label Apr 24, 2017
@MartinBasti
Copy link
Contributor

master:

  • b64ec75 tox: use pylint 1.6.x for now

@MartinBasti MartinBasti added the pushed Pull Request has already been pushed label Apr 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MartinBasti MartinBasti

Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
Milestone
No milestone
2 participants
@tiran @MartinBasti