ipa-cacert-manage: add --external-ca-type #728
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-assigned this
stlaz
reviewed
May 4, 2017
ipaserver/install/cainstance.py
Outdated
| @@ -282,7 +282,7 @@ class CAInstance(DogtagInstance): | |||
| tracking_reqs = (('auditSigningCert cert-pki-ca', None), | |||
| ('ocspSigningCert cert-pki-ca', None), | |||
| ('subsystemCert cert-pki-ca', None), | |||
| ('caSigningCert cert-pki-ca', 'ipaCACertRenewal')) | |||
| ('caSigningCert cert-pki-ca', None)) | |||
There was a problem hiding this comment.
By removing the one special snowflake, you can remove the second part of each tuple (also in KRAInstance) and simplify DogtagInstance.configure_renewal() as well
stlaz
reviewed
May 4, 2017
| @@ -939,7 +937,7 @@ def certificate_renewal_update(ca, ds, http): | |||
| 'cert-presave-command': template % 'stop_pkicad', | |||
| 'cert-postsave-command': | |||
| (template % 'renew_ca_cert "caSigningCert cert-pki-ca"'), | |||
| 'template-profile': 'ipaCACertRenewal', | |||
| 'template-profile': '', | |||
There was a problem hiding this comment.
Is the empty string here required?
There was a problem hiding this comment.
Yes, the profile name needs to be removed.
added 7 commits
May 9, 2017 05:56
Do not bypass the renewal master check when a non-virtual profile is used in dogtag-ipa-ca-renew-agent-submit. This fixes dogtag-ipa-ca-renew-agent not respecting the CA renewal master setting for certificates tracked with a real profile. (Note that there currently aren't any such certificates tracked by us.) Request the RA certificate using dogtag-submit rather than dogtag-ipa-ca-renew-agent-submit as the CA renewal master setting is not available so early in the install process. https://pagure.io/freeipa/issue/5799
Fix certmonger tracking requests on every run of ipa-server-upgrade rather than only when the tracking configuration has changed and the requests have not yet been updated. This allows fixing broken tracking requests just by re-running ipa-server-upgrade. https://pagure.io/freeipa/issue/5799
Use Dogtag's `caCACert` CA certificate profile rather than the `ipaCACertRenewal` virtual profile for lightweight CA certificates. The `ipaCACertRenewal` virtual profile adds special handling of externally signed CA certificates and LDAP replication of issued certificates on top of `caCACert`, neither of which is relevant for lightweight CA certificates. Remove all of the special casing of lightweight CA certificates from dogtag-ipa-ca-renew-agent-submit. Make sure existing lightweight CA certmonger tracking requests are updated on server upgrade. https://pagure.io/freeipa/issue/5799
Add a switch which makes `dogtag-ipa-ca-renew-agent-submit` reuse the existing certificate rather than request a new one from the CA while maintaining LDAP replication of the certificate. Make this available as a new `dogtag-ipa-ca-renew-agent-reuse` certmonger CA. This allows redoing the LDAP replication and reexecuting pre- and post-save commands of a tracking request without reissuing the certificate. https://pagure.io/freeipa/issue/5799
Make sure a CSR is exported for the IPA CA whenever certmonger detects that the CA certificate is about to expire. This is a pre-requisite for using the `dogtag-ipa-ca-renew-agent-reuse` CA instead of the `ipaCSRExport` virtual profile to export the CSR. https://pagure.io/freeipa/issue/5799
Replace all uses of virtual profiles with `dogtag-ipa-ca-renew-agent-reuse` and remove profile from the IPA CA certificate tracking request. This prevents virtual profiles from making their way into CSRs and in turn being rejected by certain CAs. This affected the IPA CA CSR with Microsoft CS in particular. https://pagure.io/freeipa/issue/5799
Add the `--external-ca-type`, as known from `ipa-server-install` and `ipa-ca-install`, to `ipa-cacert-manage`. This allows creating IPA CA CSRs suitable for use with Microsoft CS using `ipa-cacert-manage`: ``` ipa-cacert-manage renew --external-ca --external-ca-type=ms-cs ``` https://pagure.io/freeipa/issue/5799
|
LGTM |
|
Work for me. |
|
master:
|
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
server upgrade: always fix certmonger tracking request
Fix certmonger tracking requests on every run of ipa-server-upgrade rather
than only when the tracking configuration has changed and the requests have
not yet been updated.
This allows fixing broken tracking requests just by re-running
ipa-server-upgrade.
cainstance: use correct profile for lightweight CA certificates
Use Dogtag's
caCACertCA certificate profile rather than theipaCACertRenewalvirtual profile for lightweight CA certificates.The
ipaCACertRenewalvirtual profile adds special handling of externallysigned CA certificates and LDAP replication of issued certificates on top
of
caCACert, neither of which is relevant for lightweight CAcertificates.
Remove all of the special casing of lightweight CA certificates from
dogtag-ipa-ca-renew-agent-submit.
Make sure existing lightweight CA certmonger tracking requests are updated
on server upgrade.
renew agent: allow reusing existing certs
Add a switch which makes
dogtag-ipa-ca-renew-agent-submitreuse theexisting certificate rather than request a new one from the CA while
maintaining LDAP replication of the certificate.
Make this available as a new
dogtag-ipa-ca-renew-agent-reusecertmongerCA.
This allows redoing the LDAP replication and reexecuting pre- and post-save
commands of a tracking request without reissuing the certificate.
renew agent: always export CSR on IPA CA certificate renewal
Make sure a CSR is exported for the IPA CA whenever certmonger detects that
the CA certificate is about to expire.
This is a pre-requisite for using the
dogtag-ipa-ca-renew-agent-reuseCAinstead of the
ipaCSRExportvirtual profile to export the CSR.renew agent: get rid of virtual profiles
Replace all uses of virtual profiles with
dogtag-ipa-ca-renew-agent-reuseand remove profile from the IPA CA certificate tracking request.
This prevents virtual profiles from making their way into CSRs and in turn
being rejected by certain CAs. This affected the IPA CA CSR with Microsoft
CS in particular.
ipa-cacert-manage: add --external-ca-type
Add the
--external-ca-type, as known fromipa-server-installandipa-ca-install, toipa-cacert-manage.This allows creating IPA CA CSRs suitable for use with Microsoft CS using
ipa-cacert-manage:https://pagure.io/freeipa/issue/5799