Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec file: bump krb5 Requires for certauth fixes #731

Closed
wants to merge 1 commit into from
Closed

spec file: bump krb5 Requires for certauth fixes #731

wants to merge 1 commit into from

Conversation

HonzaCholasta
Copy link
Contributor

@HonzaCholasta HonzaCholasta commented Apr 25, 2017

Bump krb5-* Requires to the version which includes the final version of
certauth support.

https://pagure.io/freeipa/issue/4905

Copy link
Contributor

@martbab martbab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have one error that produces invalid specfile, please fix.

freeipa.spec.in Outdated
# 1.15.1-3: certauth (http://krbdev.mit.edu/rt/Ticket/Display.html?id=8561)
BuildRequires: krb5-devel >= 1.15.1-3
# 1.15.1-6: certauth (http://krbdev.mit.edu/rt/Ticket/Display.html?id=8561)
BuildRequires: krb5-devel >= ${krb5_version}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should replace '$' with '%' here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops.

Bump krb5-* Requires to the version which includes the final version of
certauth support.

https://pagure.io/freeipa/issue/4905
@martbab martbab added the ack Pull Request approved, can be merged label Apr 26, 2017
@martbab
Copy link
Contributor

martbab commented Apr 26, 2017

We will need a separate PR for ipa-4-5 branch.

@HonzaCholasta
Copy link
Contributor Author

@martbab, #739.

@martbab
Copy link
Contributor

martbab commented Apr 27, 2017

master:

  • 0f42670 spec file: bump krb5 Requires for certauth fixes

@martbab martbab added the pushed Pull Request has already been pushed label Apr 27, 2017
@martbab martbab closed this Apr 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
2 participants