ipa-custodia: use Dogtag's alias/pwdfile.txt #732
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Postponing, ticket milestone is 4.7 |
tiran
force-pushed
the
custodia_pwdfile
branch
from
cef8775
to
ab6735a
Compare
|
@simo5 has ACKed the change in April. |
tiran
added
ack
tiran
force-pushed
the
custodia_pwdfile
branch
from
ab6735a
to
3a41040
Compare
/etc/pki/pki-tomcat/password.conf contains additional passwords like replicadb. ipa-custodia does not need these passwords. /etc/pki/pki-tomcat/alias/pwdfile.txt holds the passphrase for Tomcat's NSSDB. The file also simplifies implementation because it removes another temporary file. pwdfile.txt is created by CAInstance.create_certstore_passwdfile() Related: https://pagure.io/freeipa/issue/6888 Signed-off-by: Christian Heimes <cheimes@redhat.com>
tiran
force-pushed
the
custodia_pwdfile
branch
from
3a41040
to
3cd45f7
Compare
|
master:
|
|
This push doesn't seem completely OK. LGTM is not an ACK because it lacks any form of testing. It was also not tested by PR CI because the PR is old. Relatively OK would be to rebase the PR, let it be tested by PR CI and then ACK/push. |
|
Now I realized that the testing by PR-CI might have happen and is not shown here, in closed PRs list. - so I may have been partly wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/etc/pki/pki-tomcat/password.conf contains additional passwords like
replicadb. ipa-custodia does not need these passwords.
/etc/pki/pki-tomcat/alias/pwdfile.txt holds the passphrase for Tomcat's
NSSDB. The file also simplifies implementation because it removes
another temporary file.
pwdfile.txt is created by CAInstance.create_certstore_passwdfile()
Related: https://pagure.io/freeipa/issue/6888
Signed-off-by: Christian Heimes cheimes@redhat.com