[4.5] Fix CA/server cert validation in FIPS #733
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akasurde
approved these changes
Apr 26, 2017
| @@ -77,6 +77,12 @@ def find_cert_from_txt(cert, start=0): | |||
| return (cert, e) | |||
|
|
|||
|
|
|||
| def get_file_cont(slot, token, filename): | |||
| with open(filename) as f: | |||
tiran
reviewed
Apr 27, 2017
ipapython/certdb.py
Outdated
| @@ -77,6 +77,12 @@ def find_cert_from_txt(cert, start=0): | |||
| return (cert, e) | |||
|
|
|||
|
|
|||
| def get_file_cont(slot, token, filename): | |||
| with open(filename) as f: | |||
| cont = f.read() | |||
stlaz
force-pushed
the
4-5-external_fips
branch
from
3490705
to
d1d8fdf
Compare
|
Made a quickfix according to @tiran, the ACK can stay. Thanks, I was being paranoid. |
In FIPS, the NSS library needs to be passed passwords to perform certificate validation. Should we not have passed it and the NSS guys have not fixed this yet, we would get SEC_ERROR_BAD_SIGNATURE which is completely different error than one would expect but that's just how things are with NSS right now. https://pagure.io/freeipa/issue/6897
stlaz
force-pushed
the
4-5-external_fips
branch
from
d1d8fdf
to
906c201
Compare
|
ipa-4-5:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In FIPS, the NSS library needs to be passed passwords to perform
certificate validation. Should we not have passed it and the NSS
guys have not fixed this yet, we would get SEC_ERROR_BAD_SIGNATURE
which is completely different error than one would expect but
that's just how things are with NSS right now.
https://pagure.io/freeipa/issue/6897