automount install: do not wait for sssd restart on uninstallation #735
Conversation
|
I guess I have more issues with the commit message than the patch content. What would you suggest ensure that sssd is up? A typical user wouldn't notice until an nss lookup failed which likely means a login was rejected. The wait for restart was there to ensure, in interactive sessions at least, that unconfiguring automount didn't hose the system. To me is another example of how wrong it is to require a ticket to initialize an API. |
|
Thanks Rob, this reason for the wait didn't occurred to me. New patch changes api initialization so that it works for both install and uninstall even without user's Kerberos credentials and with cleared cache, |
client/ipa-client-automount
Outdated
| @@ -448,7 +448,11 @@ def main(): | |||
| kinit_keytab(host_princ, paths.KRB5_KEYTAB, ccache_name) | |||
| os.environ['KRB5CCNAME'] = ccache_name | |||
| except gssapi.exceptions.GSSError as e: | |||
| sys.exit("Failed to obtain host TGT: %s" % e) | |||
| sys.exit("Failed to obtained host TGT: %s" % e) | |||
There was a problem hiding this comment.
The original line is more correct.
Change in 2d4d1a9 no longer initializes api in `ipa-client-automount --uninstallation` Which caused error in wait_for_sssd which gets realm from initialized API. This patch initializes the API in a way that it doesn't download schema on uninstallation and on installation it uses host keytab for it so it no longer requires user's Kerberos credentials. Also fix call of xxx_service_class_factory which requires api as param. https://pagure.io/freeipa/issue/6861
|
The error message was reverted to original (I was fixing the comment below and wondered why it was not fixed, now I know). |
Change in 2d4d1a9 no longer initializes
api in
ipa-client-automount --uninstallationWhich caused error inwait_for_sssd which gets realm from initialized API.
In my opinion, there is no reason to check working sssd after uninstallation by running
id command. If anything depends on running sssd then it should do the check.
Also fix call of xxx_service_class_factory which requires api as param.
https://pagure.io/freeipa/issue/6861