Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore: restart gssproxy after restore #738

Closed
wants to merge 1 commit into from
Closed

restore: restart gssproxy after restore #738

wants to merge 1 commit into from

Conversation

pvoborni
Copy link
Member

So that gssproxy picks up new configuration and therefore related
usages like authentication of CLI against server works

https://pagure.io/freeipa/issue/6902

@simo5 btw, what is the proper name of gssproxy? Is it GSSAPI proxy, gss-proxy or gssproxy?

Note: if this patch is wrong, feel free to take over and abolish this PR.

So that gssproxy picks up new configuration and therefore related
usages like authentication of CLI against server works

https://pagure.io/freeipa/issue/6902
@simo5
Copy link
Contributor

simo5 commented Apr 26, 2017

The name of the project is GSS-Proxy, the package name is gssproxy.

Copy link
Contributor

@frozencemetery frozencemetery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please HUP gssproxy rather than restarting it.

@simo5
Copy link
Contributor

simo5 commented Apr 26, 2017

will a "systemctl reload gssproxy" do the right thing @frozencemetery ?

@frozencemetery
Copy link
Contributor

The systemd-portable way to do this is as I understand it is systemctl try-reload-or-restart gssproxy (unless you want to start it if it's not running, at which point you'd do systemctl reload-or-restart gssproxy). Then you're not dependent on how the distro maintainer decides to handle it (which varies between distros here due to reasons).

That is something of an orthogonal consideration though - digging further into the code, it doesn't look like there's a reload-style verb of any kind in the services abstraction layer? (I see is_running() and restart(), but no reload() in services.py.) I don't know how you want to address this; whether it makes sense to extend the abstraction, or whether since no one else uses it gssproxy can just be restarted.

@pvoborni
Copy link
Member Author

PR #748 obsoletes this one - this PR was created badly and so I cannot force update it. New one uses reload-or-restart

@pvoborni pvoborni closed this Apr 28, 2017
@pvoborni pvoborni added the rejected Pull Request has been rejected label Apr 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rejected Pull Request has been rejected
Projects
None yet
3 participants