Check CA status: add HTTP timeout #753
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
httplib.HTTPConnection supports timeout option so _httplib_request can be updated to allow passing connection keyword arguments to connection_factory. We need connection timeout for cases when reply from server is not received on time to ask again and not to wait for infinity. https://pagure.io/freeipa/issue/6766
stlaz
reviewed
May 3, 2017
ipalib/constants.py
Outdated
| @@ -171,6 +171,9 @@ | |||
| ('ca_install_port', None), | |||
| ('ca_agent_install_port', None), | |||
| ('ca_ee_install_port', None), | |||
| # How long http connection should wait before trying again [seconds]. | |||
| # Do not mistake with "startup_timeout" | |||
| ('ca_status_http_timeout', 30), | |||
There was a problem hiding this comment.
I don't like adding this to api.env, if you really have to, can't you make this more general?
There was a problem hiding this comment.
Could be http_timeout?
CA sometimes "forgot to answer" so we have to add timeout for http connection and ask again rather than wait for infinity. https://pagure.io/freeipa/issue/6766
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://pagure.io/freeipa/issue/6766