cert-show: check if certificate_out is in options #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frasertweedale
approved these changes
May 10, 2017
ipaclient/plugins/cert.py
Outdated
| certificate_out = options.pop('certificate_out') | ||
| if certificate_out is None: | ||
| raise errors.ValidationError(name='certificate-out', | ||
| error=_(u'cannot be empty')) |
There was a problem hiding this comment.
I think this would better be checked inside check_writable_file, as that will fix the issue for other commands (e.g. ca-show as well).
There was a problem hiding this comment.
Good point. I did not notice the same check is in the ca plugin as well so I unified these.
If --certificate-out was specified on the command line, it will appear among the options. If it was empty, it will be None. This check was done properly in the ca plugin. Lets' just unify how this is handled and improve user experience by announcing which option causes the failure. https://pagure.io/freeipa/issue/6885
|
Is it ok now, then? |
|
@frasertweedale @HonzaCholasta can you please continue review of this PR? |
HonzaCholasta
added
ack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If --certificate-out was specified on the command line, it will appear
among the options. If it was empty, it will be None, though.
https://pagure.io/freeipa/issue/6885