Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide useful messages during cert validation #783

Closed
wants to merge 1 commit into from

Conversation

stlaz
Copy link
Contributor

@stlaz stlaz commented May 12, 2017

When the certificate validation was replaced, some error messages
were omitted (like "Peer's certificate expired."). Bring these back.

https://pagure.io/freeipa/issue/6945

When the certificate validation was replaced, some error messages
were omitted (like "Peer's certificate expired."). Bring these back.

https://pagure.io/freeipa/issue/6945
@stlaz stlaz changed the title Provide useful messages during cert verification Provide useful messages during cert validation May 12, 2017
@flo-renaud flo-renaud self-assigned this May 16, 2017
@flo-renaud
Copy link
Contributor

Hi @stlaz
Thank you for the patch. LGTM.

@flo-renaud flo-renaud added the ack Pull Request approved, can be merged label May 16, 2017
@MartinBasti
Copy link
Contributor

Please provide PR for ipa-4-5 branch

@MartinBasti
Copy link
Contributor

master:

  • 3d969d7 Provide useful messages during cert validation

@MartinBasti MartinBasti added the pushed Pull Request has already been pushed label May 18, 2017
@MartinBasti
Copy link
Contributor

No need for ipa-4-5 this regression is not in 4.5, master only

@stlaz stlaz deleted the verify_messages branch September 11, 2017 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
3 participants