Fix regexp in user/group name #82
Conversation
|
Would the gist of this patch also apply to any of idviews, servicedelegation or topology plugins where a similar or slightly different regexp is used? Could we rather have the regexp as a constant somewhere so it does not have to be changed at all places it appears every time we want to modify it? |
|
'uid' in user object and 'cn' in group object have meaning in POSIX environments. 'cn' in other objects is not subject for strict limits. |
|
Sure. But from what I see, this patch may possibly break idviews plugin for users of username of about 255 characters (see idoverrideuser - 'uid'), same for groups (with 'cn' ofc). |
Regexp should not enforce lenght of string, we have different checks for that. Secondly regexp with length specified produces an incorrect error message. https://fedorahosted.org/freeipa/ticket/5822
User and groups regexp are the same and constant should be used to avoid any future misconfigurations. https://fedorahosted.org/freeipa/ticket/5822
|
LGTM. Thanks for first fixing the regexp and then replacing it by a constant, this will help with backports. |
|
The tests seem to pass as well. |
Regexp should not enforce lenght of string, we have different checks for
that. Secondly regexp with length specified produces an incorrect error
message.
https://fedorahosted.org/freeipa/ticket/5822