Added a fix for setting Priority as required field #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stlaz
requested changes
Sep 15, 2016
| }); |
There was a problem hiding this comment.
Please, turn off newlines at the end of file in your text editor and/or fix this. Other than that LGTM.
stlaz
approved these changes
Sep 15, 2016
|
Looks OK to me, thanks. |
|
@stlaz Thanks |
|
Sorry guys, but ticket is in closed milestone you need a new one. |
|
@mbasti-rh I re-opened the ticket, Could you please provide ack ? |
|
@Akasurde I said we need a new ticket for it. I opened one for you https://fedorahosted.org/freeipa/ticket/6335 |
… Details facet Fixes: https://fedorahosted.org/freeipa/ticket/6335 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
|
Fixed upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://fedorahosted.org/freeipa/ticket/6335
Signed-off-by: Abhijeet Kasurde akasurde@redhat.com