Made sssd restart a non-raising opration #86
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uninstallation of ipa-server usually removes sssd configuration file, /etc/sssd/sssd.conf If we then issue syustemctl restart sssd.service, the command fails because is unable to find the config file. We need to make this call not raise an exception
MartinBasti
suggested changes
Sep 15, 2016
| @@ -691,7 +691,7 @@ def uninstall_master(host, ignore_topology_disconnect=True, | |||
| "xargs rm -fv", raiseonerr=False) | |||
| host.run_command("find /run/ipa -name 'krb5*' | xargs rm -fv", | |||
| raiseonerr=False) | |||
| host.run_command(['systemctl', 'restart', 'sssd']) | |||
| host.run_command(['systemctl', 'restart', 'sssd'], raiseonerr=False) | |||
There was a problem hiding this comment.
Why do we even need to restart SSSD when server is uninstalled?
|
I was thinking hard about it, if there should be SSSD restart, but I cannot find any case where it is needed after server uninstall |
|
Probably Lenka has some use-case for this. I am pretty sure these lines weren't added just for fun :) |
|
Can wait until Lenka give us the reason? |
|
sure |
|
Hi, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uninstallation of ipa-server usually removes sssd configuration file,
/etc/sssd/sssd.conf
If we then issue syustemctl restart sssd.service, the command fails because is
unable to find the config file. We need to make this call not raise an
exception