Pylint fixes #97
Closed
Pylint fixes #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkrizek
reviewed
Sep 22, 2016
| else: | ||
| cmd_result['revoked'] = False | ||
|
|
||
| return cmd_result |
There was a problem hiding this comment.
do not remove the return statement
| cls.__outer_class__ = outer_class | ||
| cls.__outer_name__ = name | ||
| cls.__name__ = '.'.join((outer_class.__name__, name)) | ||
| cls.__qualname__ = outer_class.__name__ |
There was a problem hiding this comment.
this should be cls.__qualname__ = cls.__name__
|
NACK, please see inline comments |
tkrizek
suggested changes
Sep 22, 2016
|
|
||
| return cmd_result | ||
| return cmd_result |
|
Please fix the typo. |
tkrizek
approved these changes
Sep 22, 2016
added 8 commits
September 22, 2016 16:02
fix inefficient if statements, enable pylint check
|
I had to rebase, there were conflicts due the latest pushed patches |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated pylint fixes from Jan Barta