Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_dnssec: re-add named-pkcs11 workarounds #973

Closed

Conversation

@tomaskrizek
Copy link
Contributor

commented Aug 15, 2017

DNSSEC tests starrted to fail again, probably due to a bug in
some underlaying component.

This reverts commit 8bc6775
and makes the xfail test check less strict - it will no longer
mark the test suite red if it passes.

Related https://pagure.io/freeipa/issue/5348

@tomaskrizek tomaskrizek added the WIP label Aug 15, 2017
@tomaskrizek tomaskrizek force-pushed the tomaskrizek:dnssec_tests_workarounds branch 2 times, most recently from 7847c3f to 8b493ef Aug 15, 2017
@tomaskrizek

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2017

This does seem to fix the test suite.

Link to test run: https://fedorapeople.org/groups/freeipa/prci/jobs/2fffc1c0-81ac-11e7-97c3-001a4a2316f3/

It's interesting that the xfail has passed -- perhaps the issue isn't always happen, or the added test doesn't correctly cover the issue.

@tomaskrizek tomaskrizek removed the WIP label Aug 15, 2017
@tomaskrizek

This comment has been minimized.

Copy link
Contributor Author

commented Aug 16, 2017

2 failed tests in the second run, the test suite is either unstable or the problem may be elsewhere.

https://fedorapeople.org/groups/freeipa/prci/jobs/e1c98672-81c8-11e7-bee1-001a4a2316f3/

@tomaskrizek tomaskrizek added the WIP label Aug 17, 2017
@tomaskrizek tomaskrizek added postponed and removed WIP labels Sep 21, 2017
@tomaskrizek tomaskrizek referenced this pull request Nov 15, 2017
@tiran tiran added re-run and removed postponed labels Nov 15, 2017
@tiran

This comment has been minimized.

Copy link
Member

commented Nov 15, 2017

@tomaskrizek suggested to fix and merge this fix first for #1011

@felipevolpone felipevolpone removed the re-run label Nov 15, 2017
Tomas Krizek
DNSSEC tests starrted to fail again, probably due to a bug in
some underlaying component.

This reverts commit 8bc6775
and makes the xfail test check less strict - it will no longer
mark the test suite red if it passes.

Related https://pagure.io/freeipa/issue/5348
@tomaskrizek tomaskrizek force-pushed the tomaskrizek:dnssec_tests_workarounds branch from 8b493ef to 3b35013 Nov 15, 2017
@tiran

This comment has been minimized.

Copy link
Member

commented Feb 9, 2018

I have created a new PR #1559 to finish @tomaskrizek PR.

@tiran tiran closed this Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.