Skip to content
Permalink
Browse files Browse the repository at this point in the history
Uses SOURCE_DATE_EPOCH for build time if available to makes build rep… 
…roducible (patch contributed by Chris Lamb).
  • Loading branch information
@s-vincent
s-vincent committed Aug 12, 2017
1 parent 1905d90 commit 97b049b
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion defines.py
View file
Expand Up @@ -3,6 +3,7 @@
"""

import os
import time
import argparse
import inspect
import datetime
Expand Down Expand Up @@ -78,7 +79,7 @@ def version_str(self):
@property
def date(self):
if self._date is None:
self._date = datetime.date.today().strftime('%a %d %b %Y')
self._date = datetime.datetime.utcfromtimestamp(int(os.environ.get('SOURCE_DATE_EPOCH', time.time()))).strftime('%a %d %b %Y')

return self._date

Expand Down

4 comments on commit 97b049b

@leggewie
Copy link
Member

@leggewie leggewie commented on 97b049b Apr 15, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch was courtesy of Chris Lamb (@lamby) and should have been more prominently credited as such (git commit has --author)
https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/freelan.html

@lamby
Copy link

@lamby lamby commented on 97b049b Apr 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @leggewie.

I've always been fascinated by the number of maintainers who do not attribute patches in changelogs, especially from newcomers. I would certainly concede that it adds nothing technical and can even be distracting, but it seems a reasonable concession that dramatically increases the chance of future efforts or, frankly, is simply a kindly gesture of thanks and good will. Given our level of technical expertise, I fear we regularly suffer from not having sufficient empathy for newcomers or first-time users who lack the context or orientation that we possess. :)

@s-vincent
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leggewie @lamby Sorry for that. At least contributor name is in the commit log ("contributed by...") but I agree it should be the commit author directly.

@lamby
Copy link

@lamby lamby commented on 97b049b Apr 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No biggie!

Please sign in to comment.