Skip to content
This repository has been archived by the owner on Feb 23, 2022. It is now read-only.

Some minor code shortenings #10

Merged
merged 5 commits into from Aug 20, 2018
Merged

Some minor code shortenings #10

merged 5 commits into from Aug 20, 2018

Conversation

jamolkhon
Copy link
Contributor

Including #8

sockeqwe
sockeqwe reviewed Aug 18, 2018
View reviewed changes
sample/src/main/java/com/freeletics/rxredux/util/Extensions.kt Outdated
inline fun <reified T : ViewModel> FragmentActivity.viewModel(factory: ViewModelProvider.Factory)
= ViewModelProviders.of(this, factory)[T::class.java]

inline fun <reified T : ViewModel> Fragment.viewModel(factory: ViewModelProvider.Factory)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method is not used.

sockeqwe
sockeqwe approved these changes Aug 20, 2018
View reviewed changes
Copy link
Contributor

@sockeqwe sockeqwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sockeqwe sockeqwe merged commit 74abe94 into freeletics:master Aug 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sockeqwe sockeqwe sockeqwe approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jamolkhon @sockeqwe