Skip to content

Vet actions with zizmor - #659

Merged
philipqueen merged 5 commits into
mainfrom
philip/vet_actions_with_zizmor
Dec 20, 2024
Merged

Vet actions with zizmor#659
philipqueen merged 5 commits into
mainfrom
philip/vet_actions_with_zizmor

Conversation

@philipqueen

@philipqueen philipqueen commented Dec 17, 2024

Copy link
Copy Markdown
Collaborator

While looking into the recent Ultralytics vulnerability, I came across zizmor. This is a security linting tool for github actions. I decided to run it as part of our recent push to ensure our actions security is solid.

Changes:

  • remove the unused ci.yml - this only triggered when a multi year old branch was edited, might as well reduce the attack surface and clean out some old code.
  • add persist-credentials: false to all checkout actions. this reduces the chance of accidentally leaking tokens: https://woodruffw.github.io/zizmor/audits/#artipacked
  • Change to Trusted Publishing - this is an "info" level warning, but probably still a good idea. There's more info here: https://woodruffw.github.io/zizmor/audits/#use-trusted-publishing
  • add a workflow to run zizmor whenever a workflow is changed - meta CI/CD, if you will - to ensure we don't regress in the future

@github-advanced-security

Copy link
Copy Markdown

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@philipqueen philipqueen added the ready for review Pull request is ready for final review label Dec 20, 2024
@philipqueen
philipqueen merged commit 9fc8b88 into main Dec 20, 2024
@philipqueen
philipqueen deleted the philip/vet_actions_with_zizmor branch December 20, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review Pull request is ready for final review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants