Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Sharing:iSCSI Target to Extent to Middlewared #1232

Merged
merged 2 commits into from May 17, 2018

Conversation

Projects
None yet
2 participants
@skarekrow
Copy link
Contributor

commented May 17, 2018

Ticket: #33612

@skarekrow skarekrow requested a review from william-gr May 17, 2018

class iSCSITargetToExtentForm(ModelForm):
class iSCSITargetToExtentForm(MiddlewareModelForm, ModelForm):
middleware_attr_prefix = "iscsi_"
middleware_attr_schema = "services.iscsi_targetextent"

This comment has been minimized.

Copy link
@william-gr

william-gr May 17, 2018

Member

iscsi_targetextent_


@accepts(Dict(
'iscsi_targetextent_create',
Int('target'),

This comment has been minimized.

Copy link
@william-gr

william-gr May 17, 2018

Member

target and extent are required

async def extend(self, data):
print('+'*50)
print(data)
print('+'*50)

This comment has been minimized.

Copy link
@william-gr
return await self.middleware.call(
'datastore.delete', self._config.datastore, id)

@private

This comment has been minimized.

Copy link
@william-gr

william-gr May 17, 2018

Member

Remove compress?

old_lunid = old.get('lunid')
print('*'*50)
print(old_lunid)
print('*'*50)

This comment has been minimized.

Copy link
@william-gr
filters = [('id', '=', lunid), ('target', '=', target)]
result = self.query(filters)

if old_lunid != lunid and result:

This comment has been minimized.

Copy link
@william-gr

william-gr May 17, 2018

Member

Extra indentation

@skarekrow skarekrow force-pushed the FIX-33612 branch 2 times, most recently from fabefd7 to 1b4071b May 17, 2018

@skarekrow skarekrow force-pushed the FIX-33612 branch from 1b4071b to a9173c7 May 17, 2018

@skarekrow skarekrow merged commit 67f5bc8 into master May 17, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@skarekrow skarekrow deleted the FIX-33612 branch May 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.