Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugins/jail): Bad caching on list_resource #1535

Merged
merged 2 commits into from Jul 13, 2018
Merged

Conversation

skarekrow
Copy link

This caused a remote cache to be consumed by a local cache. They are now distinct.

Ticket: #37706

This caused a remote cache to be consumed by a local cache. They are now distinct.

Ticket: #37706
@ghost ghost assigned skarekrow Jul 12, 2018
@ghost ghost added the review label Jul 12, 2018
Copy link
Member

@william-gr william-gr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need to cache local releases? We would need to invalidate them after fetch, seems a lot of trouble

@skarekrow
Copy link
Author

I can remove that bit

@william-gr
Copy link
Member

@skarekrow I believe we shoud. I dont think local search is such a problem that requires a cache. It will only create problems.

@skarekrow skarekrow merged commit e82eeff into master Jul 13, 2018
@ghost ghost removed the review label Jul 13, 2018
@skarekrow skarekrow deleted the FIX-37706_jail branch July 13, 2018 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants