tkt-42090: Improved arcstat. Added -a option to automatically print all valid st… #1702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atistics. Added -p option to suppress scaling of printed data. Changed printing so that there is no longer a trailing seperator character at the end of every line. Ticket: #42090
ghost
assigned 
william-gr
approved these changes
Aug 20, 2018
william-gr
reviewed
Aug 20, 2018
src/freenas/usr/local/bin/arcstat.py
Outdated
| @@ -224,26 +227,48 @@ def prettynum(sz, scale, num=0): | |||
| else: | |||
| return "%*d%s" % (sz - 1, num, suffix[index]) | |||
|
|
|||
| def print_with_sep(value, sep, first): | |||
There was a problem hiding this comment.
Need one more blank line before and after this method to make PEP8 happy.
amotin
reviewed
Aug 20, 2018
bugclerk
changed the title
william-gr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…atistics. Added -p option to suppress scaling of printed data. Changed printing so that there is no longer a trailing seperator character at the end of every line.
Ticket: #42090