NAS-105957 / 11.3 / Add to debug #4673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gather middleware configuration for system.general, system.advanced, and network.configuration. Expand content for LDAP and AD directory services.
sonicaj
reviewed
Apr 29, 2020
There was a problem hiding this comment.
I think we should use sqlite where we can, it's possible middleware crashed and we would not get the response back with rest of the bits in the db. Though not so sure about it. @william-gr, @themylogin thoughts ?
|
@sonicaj If the middleware is crashed, we don't care for these missing bits. I like the code being simpler and exposing more necessary information. |
themylogin
approved these changes
Apr 29, 2020
sonicaj
approved these changes
Apr 29, 2020
There was a problem hiding this comment.
Thank you for clarifying @themylogin, I was torn at that bit.
|
backport |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.