Mineos plugin #24
Merged
Mineos plugin #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
skarekrow
requested changes
Jun 26, 2018
INDEX
Outdated
| "mineos": { | ||
| "MANIFEST": "mineos.json", | ||
| "name": "MineOS", | ||
| "primary_pkg": "https://github.com/hexparrot/mineos-node", |
There was a problem hiding this comment.
He's grabbing the master branch, so make this look like the sickrage entry for primary_pkg
skarekrow
approved these changes
Jun 27, 2018
|
Hi @skarekrow |
|
Yeah we just aren't merging until the freeze on our repos is over
…On Wed, Jul 4, 2018, 9:40 PM jsegaert ***@***.***> wrote:
Hi @skarekrow <https://github.com/skarekrow>
Is this good to merge?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#24 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABg_N66H7b5cYBH5r4S3Lay93VOgM5SSks5uDXyZgaJpZM4U37Yg>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will not have a 'true' value for the 'official' flag? It was designed by jsegaert. His artifact repo can be found at:
https://github.com/jsegaert/iocage-plugin-mineos