Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add confirm dialogs to options to switch to legacy UI #735

Merged
merged 3 commits into from May 19, 2018

Conversation

dkmullen
Copy link
Contributor

Ticket: #33426

@erincodepirate
Copy link
Contributor

This doesn't work on mine, I tried building it and hotpatching my box but the sending to /legacy/ doesn't work. I think the reason is that you are trying to use the router which would try to send the user to /ui/legacy rather than /legacy since the router only works within the app itself. Try using window.location.href = /legacy/ instead.

@erincodepirate
Copy link
Contributor

rebuild

@erincodepirate
Copy link
Contributor

LGTM

@erincodepirate erincodepirate merged commit 94317ac into master May 19, 2018
@erincodepirate erincodepirate deleted the fix/legacy-ui-switch-dialog-33426 branch May 19, 2018 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants